-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fixtures/specs): Transaction tests #933
base: main
Are you sure you want to change the base?
Conversation
Look at transaction test filler We used to have t9n in geth to ask the client for transaction test validity Now we have python implementation of transaction Basically its like difficulty test. Lets say we test data field. Then we iterate by forks by tx types. Data is empty - tx valid The exception here is. In this tests we don't care about pre or post state and out of funds exceptions or out of gas exceptions Same for gaslimit field. While transaction structure remains valid. Also for int fields we test rlp encryption. This test you can also treat as transaction deserialization tests from rlp. Because we can put an extra field in rlp or remove one. Or mess rlp headers. |
cdc8936
to
d1028ea
Compare
d1028ea
to
61e8fc9
Compare
🗒️ Description
Transaction Test Format
Introduce the Transaction test type to EEST.
TODOs:
ethereum/tests
At the moment the spec only generates the transaction fixture type, and automatically generating blockchain and engine blockchain tests could be added in the future.
Fixture format type in
_info
A new info key
fixture_format
is added to the_info
dictionary in the generated fixtures.This is done in order to better discriminate between fixture formats, since the addition of the transaction test format was causing issues in
checkfixtures
command.🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.