Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - Tests from Fuzzing #756

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Aug 21, 2024

🗒️ Description

A collection of fuzzing related updates to the test

  • Activate functions validation tests, and move to 4750 dir
  • Add terminal opcode to some tests so they have only one error
  • Tests found via fuzzing coverage
    • subcontainer wrong size
    • subcontainer wrong eof version
    • EOFCREATE nonexistant container
    • Many CALLF test covered by inactive 4750 checks

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of small comments. Thanks!

@pdobacz
Copy link
Collaborator

pdobacz commented Aug 22, 2024

@shemnon If the new test cases cover cases reported in ipsilon/eof#146, please tick them off as "covered in EEST" with a corresponding link maybe (best by editing the respective comments there). Thank you!

@marioevz marioevz changed the title EOF Tests from Fuzzing new(tests): EOF - Tests from Fuzzing Aug 22, 2024
@marioevz
Copy link
Member

Please feel free to merge once the comments by @pdobacz have been addressed and conflicts have been resolved.

A collection of fuzzing related updates to the test
* Activate functions validation tests, and move to 4750 dir
* Add terminal opcode to some tests so they have only one error
* Tests found via fuzzing coverage
  * subcontainer wrong size
  * subcontainer wrong eof version
  * EOFCREATE nonexistant container
  * Many CALLF test covered by inactive 4750 checks

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon requested a review from marioevz August 28, 2024 00:16
@shemnon
Copy link
Collaborator Author

shemnon commented Aug 28, 2024

@marioevz - I added a few more tests from the fuzzing page. Tried to reduce them as far as I could to their simplest state.

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon merged commit 681f3a3 into ethereum:main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants