Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): update fixtures workflows and rename tox workflow #582

Merged
merged 3 commits into from
May 31, 2024
Merged

fix(ci): update fixtures workflows and rename tox workflow #582

merged 3 commits into from
May 31, 2024

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented May 31, 2024 •
edited
Loading

🗒️ Description

Prevents the build fixtures action from being executed when pushing to main.

Renames test.yaml workflow to tox_verify.yaml.

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@spencer-tb spencer-tb added type:bug Something isn't working scope:ci Scope: Continuous Integration labels May 31, 2024
marioevz
marioevz approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spencer-tb spencer-tb changed the title fix(ci): update fixtures feature workflow fix(ci): update fixtures workflows and rename tox workflow May 31, 2024
@marioevz marioevz merged commit 8b4504a into ethereum:main May 31, 2024
5 checks passed
spencer-tb added a commit to spencer-tb/execution-spec-tests that referenced this pull request Jun 1, 2024
@spencer-tb
fix(ci): update fixtures workflows and rename tox workflow (ethereum#582
a261311 
)

* fix(ci): update fixtures feature workflow.

* fix(ci): update fixtures workflow.

* fix(ci): rename tox workflow file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:ci Scope: Continuous Integration type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencer-tb @marioevz