Update EIP-4844: Rename "data gas" to "blob gas" #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
requested review from
marioevz and
danceratopz
and removed request for
marioevz
|
Lets wait until some of the other PRs are merged first, changing this to draft. Will rebase afterwards! |
danceratopz
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Thanks for getting on this so quickly! And for the geth branch! 🏃
I changed BLOB_GAS_PER_BLOB to GAS_PER_BLOB to bring it inline with ethereum/EIPs@f1493f6#diff-c72ce77807acfea9e9693b7999f247841df938c9645be37013903805fa8b0c09R58
I could successfully fill tests/cancun/eip4844_blobs/ with spencer-tb/go-ethereum@d8c8d09
LGTM!
marioevz
force-pushed
the
data-gas-to-blob-gas
branch
from
4ea1cd9
to
0aed72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ Adds the appropriate changes to fields that contain "data gas" (I hope there is no mistakes...).
Required for devnet-8.
Spec change: ethereum/EIPs#7354
The following geth t8n branch can be used to fill 4884 & 4788 tests:
https://github.com/spencer-tb/go-ethereum/commits/cancun-t8n