feature: Pass Correct Fork Name to T8N on Transition Forks #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
force-pushed
the
auto-transition-forks
branch
from
fbd5715
to
835b585
Compare
danceratopz
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Rebased to get besu support that was added in #206.
Looks good! I did wonder about two changes to keep rather framework-specific code out of the transition tool interface implementation:
- Change base fork's
fork()signature to take keyword arguments with default values in order to get "reasonable" default behaviour that return the merged fork. - Avoid adding additional function arguments to transition tools'
evaulate()methods.
More clarification below.
marioevz
force-pushed
the
auto-transition-forks
branch
from
323f00e
to
75fd088
Compare
Co-authored-by: danceratopz <danceratopz@gmail.com>
marioevz
force-pushed
the
auto-transition-forks
branch
from
75fd088
to
467455c
Compare
Co-authored-by: danceratopz <danceratopz@gmail.com>
marioevz
force-pushed
the
auto-transition-forks
branch
from
22e541d
to
713ea63
Compare
danceratopz
reviewed
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Included
BerlinToLondonAt5, onlyBerlinandLondonforks are now passed to the transition on the appropriate block numberFixes #208