all: Completely remove external block building tool, build blocks internally, sign transactions internally #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
changed the title
spencer-tb
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Super impressed with this and glad to be rid of bllr - happy to merge as is 💯 🚀 , all comments relate to how we can improve and refactor types.py in the future - I think we should move the json encoder to separate file
I'd read my comments from the bottom upwards :D
spencer-tb
reviewed
Jun 30, 2023
marioevz
force-pushed
the
build-blocks-internally
branch
from
f4e049b
to
0a3f8d5
Compare
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removes all references to
b11rtool and builds the blocks internally.Also all transaction types are now signed internally.