-
Notifications
You must be signed in to change notification settings - Fork 190
feat(tests): add consolidations & withdrawal requests with call_depth>2
#1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I debugged a bit but I also could not find the culprit for the failing tests. My gut says is either:
|
6e8b8fa to
527e335
Compare
|
These tests now fill with EELS, all clients pass via consume engine. I would like to better understand the limitations on the call depth, as it doesn't match what I'd expect with gas consumption, but I think they're good enough for now. |
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all tests passing. Created issue #1469 of an idea that spawned from this review.
…h>2` (ethereum#1415) * feat(tests): add consolidations & withdrawal requests with `call_depth>2` * fix(tests): increase `gas_limit`; reduce depth * fix(tests): fix tx_gas_limit, reduce depth, make test id consistent
…h>2` (ethereum#1415) * feat(tests): add consolidations & withdrawal requests with `call_depth>2` * fix(tests): increase `gas_limit`; reduce depth * fix(tests): fix tx_gas_limit, reduce depth, make test id consistent
…h>2` (ethereum#1415) * feat(tests): add consolidations & withdrawal requests with `call_depth>2` * fix(tests): increase `gas_limit`; reduce depth * fix(tests): fix tx_gas_limit, reduce depth, make test id consistent
🗒️ Description
Running coverage on the test cases themselves revealed that although
helpers.pyhandled the case for higher call depths inupdate_pre:execution-spec-tests/tests/prague/eip7251_consolidations/helpers.py
Lines 190 to 212 in ad5c0ad
the logic was never hit in L197:L212.
This PR adds some tests which trigger requests with a
call_depth > 2.TODO
tests/prague/eip7251_consolidations/test_consolidations.py::test_consolidation_requests[fork_Prague-blockchain_test-single_block_multiple_consolidation_requests_from_contract_call_depth_high]🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.