Skip to content

fix(tests): EIP-7702: send tx of eoa after setcode tx is mined #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

fix(tests): EIP-7702: send tx of eoa after setcode tx is mined #1411

merged 4 commits into from
Apr 8, 2025

Conversation

sonhv0212
Copy link
Contributor

🗒️ Description

Currently, the test test_eoa_tx_after_set_code is including both setcode tx that sets code for an EOA and tx using EOA as sender in same block. However, it is invalid due to changes introduced in this PR ethereum/go-ethereum#31430. When I try to run this test in execute mode, the second tx is rejected with the error gapped-nonce tx from delegated accounts

Here is my solution to fix it:

  • I split txs into two blocks; the first includes setcode tx that set code for an EOA, and the second is the tx from that EOA
  • We need to ensure txs of two different blocks must be included in different block as their order in node, so I refactored TransactionPost a little bit to send batches of txs by block.

@sonhv0212 sonhv0212 force-pushed the fix/eip7702-test-eoa-after-setcode branch from e2f83b3 to 61af666 Compare April 8, 2025 10:17
@sonhv0212
Copy link
Contributor Author

cc @marioevz , seems that you're the author of this test case. Can you help me verify this?
Thank you!!! 😄

@sonhv0212 sonhv0212 force-pushed the fix/eip7702-test-eoa-after-setcode branch from 61af666 to 45aaf92 Compare April 8, 2025 10:19
marioevz
marioevz approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for these changes, I think it's a good idea to make this distinction.

I added a parametrization to fill the same test as it existed before this PR, whilst skipping it for execute, and the new variant you introduced.

@marioevz marioevz merged commit efc39d5 into ethereum:main Apr 8, 2025
11 checks passed
pacrob pushed a commit to pacrob/execution-spec-tests that referenced this pull request May 5, 2025
@sonhv0212 @marioevz @pacrob
fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (
e5dd756 
ethereum#1411)

* fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined

* refactor(execute): send batch of txs by block

* fix(tests): Parametrize instead of change

* refactor(execution): Change error check to per-block basis

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@sonhv0212 @marioevz @felix314159
fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (
6c25961 
ethereum#1411)

* fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined

* refactor(execute): send batch of txs by block

* fix(tests): Parametrize instead of change

* refactor(execution): Change error check to per-block basis

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
sonhv0212 added a commit to ronin-chain/execution-spec-tests that referenced this pull request May 19, 2025
@sonhv0212 @marioevz
fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (
73f91f9 
ethereum#1411)

* fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined

* refactor(execute): send batch of txs by block

* fix(tests): Parametrize instead of change

* refactor(execution): Change error check to per-block basis

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
sonhv0212 added a commit to ronin-chain/execution-spec-tests that referenced this pull request May 20, 2025
@sonhv0212 @marioevz
fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (
19b8201 
ethereum#1411)

* fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined

* refactor(execute): send batch of txs by block

* fix(tests): Parametrize instead of change

* refactor(execution): Change error check to per-block basis

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
sonhv0212 added a commit to ronin-chain/execution-spec-tests that referenced this pull request May 21, 2025
@sonhv0212 @spencer-tb
@gumb0 @chfast @marioevz @winsvega @raxhvl @reedsa @fselmo @danceratopz @pdobacz
new(tests): sync prague tests (#32)
12850ce 
* feat(tests): EIP-2537: add bls12 audit test cases (ethereum#1275)

* fix(test): remove test violating EIP-7523 (ethereum#1257)

* fix(test): remove test violating EIP-7523

* Simplify the test by removing parameterization

* chore(tests): update bls12 test vectors (ethereum#1289)

* new(tests): add state test with empty 7702 authorization list (ethereum#1224)

* new(tests): add state test with empty 7702 authorization list

* fix(clis): Add exception to EELS

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>

* new(tests): EIP-7702: Sender not EOA test

* Add self-sponsored variant

* apply comments

* fix(test): improve EIP-7702 test for type 4 transaction with empty to (ethereum#1337)

* fix(tests): EIP-7702 verification/merge issue (ethereum#1358)

* new(tests): EIP-7702: More RLP tests (ethereum#1347)

* refactor(types): remove nonce-as-list from auth list

* new(tests): EIP-7702: Tx serialization tests

* refactor(tests): Use RLP encoding changes

* Change log

* new(tests): EIP-7702: more rlp tests

* 🧹 chore(EIP-7623): Remove duplicate fixture (ethereum#1381)

Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>

* feat(tests): Additional EIP-2935 coverage (ethereum#1379)

Update CHANGELOG.md

* new(tests): EIP-7702: Delegation Designation as Initcode, max-fee-per-gas tests (ethereum#1372)

* new(tests): EIP-7702: Delegation designation as initcode

* new(tests): EIP-7702: Invalid max_fee_per_gas/max_priority_fee_per_gas

* docs: changelog

* refactor(tests): Combine similar cases into one

Co-Authored-By: spencer <spencer.taylor-brown@ethereum.org>

---------

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

* fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (ethereum#1411)

* fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined

* refactor(execute): send batch of txs by block

* fix(tests): Parametrize instead of change

* refactor(execution): Change error check to per-block basis

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>

* feat(tests): update 7702 precompile test cases (ethereum#1431)

- Add a test case that calls the delegated precompile acct directly from
  the same transaction as the auth. Supply enough gas only to cover the
  intrinsic cost of the call, with no extra gas for any precompile
  code execution.

- Update the test case for all call opcodes to use all of the call opcodes.

* feat(tests): eip7623 - parametrize `test_transaction_validity_type_*` with a tx to an eoa (ethereum#1422)

* feat(tests): EIP-2537: extra BLS12-381 coverage (ethereum#1350)

* feat(tests): bls point generator and extra coverage.

* chore(tests): remove bls msm duplicates.

* chore: fix tox issues.

* feat(tests): Add more msm invalid tests

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>

* new(tests): EIP-7702 - ensure DELEGATECALLing a 7702 target works (ethereum#1485)

Co-authored-by: Mario Vega <marioevz@gmail.com>

* feat(tests): add bls map to curve on identity cases (ethereum#1505)

* fix(tests): EIP-7702: use penultimate block number instead of fixing block 0 (ethereum#1390)

* fix(tests): EIP-7702: use penultimate block number instead of fixing block 0

* fix(tests): EIP-7702: use contract code to get blocknumber instead of rpc

* Update uv.lock

* Update uv.lock

* Update uv.lock

* Update uv.lock

* Update pyproject.toml

* refactor(base_types,types,tests): Create RLP Serialization Classes (ethereum#1359)

* fix(types): tests: Add serialization unit tests

* fix(types): tests: Fix unit tests

* feat(base_types): Implement serialization RLP types

* feat(base_types,types,fixtures): Apply serialization RLP types

* fix(types): Auth tuple defaults

* fix(fixtures,rpc,specs,types,tests): Transaction.rlp is a function

* fix(base_types,types,rpc): fixes

* refactor(base_types,types): Network wrapped transaction

* fix(tests): Network wrapped transactions

* fix(types): Fix NetworkWrappedTransaction rlp prefix

* docs: Changelog

* Apply suggestions from code review

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

* Add network wrapper explanation

* fix: tox

* Update docs/CHANGELOG.md

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

* Add comment

---------

Co-Authored-By: spencer <spencer.taylor-brown@ethereum.org>

* fix(tests): EIP-2537: mark slow

* fix(tests): EIP-7623: remove blob in blob tx

* fix(dependency): update prague execution specs

* new(dependency): add joblib

---------

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
Co-authored-by: Paweł Bylica <pawel@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Dimitry Kh <dimitry@ethereum.org>
Co-authored-by: raxhvl <10168946+raxhvl@users.noreply.github.com>
Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: Stuart Reed <stuart.reed@ethereum.org>
Co-authored-by: felipe <fselmo2@gmail.com>
Co-authored-by: danceratopz <danceratopz@gmail.com>
Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jul 1, 2025
@sonhv0212 @marioevz @Carsons-Eels
fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (
c40ab69 
ethereum#1411)

* fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined

* refactor(execute): send batch of txs by block

* fix(tests): Parametrize instead of change

* refactor(execution): Change error check to per-block basis

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonhv0212 @marioevz