Suggestions for #1396, refactor(exceptions,specs): Support general block exceptions - Pydantic context to parse using mapper #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
marioevz
merged commit 3355296
into
ethereum:support-block-exceptions-refactor-mapper
11 checks passed
marioevz
pushed a commit
that referenced
this pull request
Apr 8, 2025
…ock exceptions - Pydantic context to parse using mapper (#1404) * refactor(fw): use enum helper; rename `ty` to `execution_context` * refactor(fw): use more specific names for exception classes
marioevz
added a commit
that referenced
this pull request
Apr 8, 2025
…ic context to parse using mapper (#1396) * feat(clis,exceptions,specs): Pydantic validation using exception mapper * fix(specs): Skip block exception check on requests modifications * fix(docs): Links * fix(tests): EIP-4844: mark block as skip block exception verification * refactor(exceptions): Mapper mappings allow regex, convert from `property` to `ClassVar` * fix(docs): tox * chore(deps): remove now unused bdict dependency * Suggestions for #1396, refactor(exceptions,specs): Support general block exceptions - Pydantic context to parse using mapper (#1404) * refactor(fw): use enum helper; rename `ty` to `execution_context` * refactor(fw): use more specific names for exception classes * fix(tests): Add comment explaining `skip_exception_verification` * feat(clis): Add `reliable` flag to exception mapper class * fix: tests * fix(specs,clis,tools): Use `default_t8n` and remove `run_in_serial` from most unit tests * fix(specs): Bug and variable names * fix: bug * feat(clis/evmone): Add insufficient-blob-fee error * fix(tests): Allow similar blob exceptions * Apply suggestions from code review Co-authored-by: danceratopz <danceratopz@gmail.com> --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
pacrob
pushed a commit
to pacrob/execution-spec-tests
that referenced
this pull request
May 5, 2025
…ic context to parse using mapper (ethereum#1396) * feat(clis,exceptions,specs): Pydantic validation using exception mapper * fix(specs): Skip block exception check on requests modifications * fix(docs): Links * fix(tests): EIP-4844: mark block as skip block exception verification * refactor(exceptions): Mapper mappings allow regex, convert from `property` to `ClassVar` * fix(docs): tox * chore(deps): remove now unused bdict dependency * Suggestions for ethereum#1396, refactor(exceptions,specs): Support general block exceptions - Pydantic context to parse using mapper (ethereum#1404) * refactor(fw): use enum helper; rename `ty` to `execution_context` * refactor(fw): use more specific names for exception classes * fix(tests): Add comment explaining `skip_exception_verification` * feat(clis): Add `reliable` flag to exception mapper class * fix: tests * fix(specs,clis,tools): Use `default_t8n` and remove `run_in_serial` from most unit tests * fix(specs): Bug and variable names * fix: bug * feat(clis/evmone): Add insufficient-blob-fee error * fix(tests): Allow similar blob exceptions * Apply suggestions from code review Co-authored-by: danceratopz <danceratopz@gmail.com> --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
…ic context to parse using mapper (ethereum#1396) * feat(clis,exceptions,specs): Pydantic validation using exception mapper * fix(specs): Skip block exception check on requests modifications * fix(docs): Links * fix(tests): EIP-4844: mark block as skip block exception verification * refactor(exceptions): Mapper mappings allow regex, convert from `property` to `ClassVar` * fix(docs): tox * chore(deps): remove now unused bdict dependency * Suggestions for ethereum#1396, refactor(exceptions,specs): Support general block exceptions - Pydantic context to parse using mapper (ethereum#1404) * refactor(fw): use enum helper; rename `ty` to `execution_context` * refactor(fw): use more specific names for exception classes * fix(tests): Add comment explaining `skip_exception_verification` * feat(clis): Add `reliable` flag to exception mapper class * fix: tests * fix(specs,clis,tools): Use `default_t8n` and remove `run_in_serial` from most unit tests * fix(specs): Bug and variable names * fix: bug * feat(clis/evmone): Add insufficient-blob-fee error * fix(tests): Allow similar blob exceptions * Apply suggestions from code review Co-authored-by: danceratopz <danceratopz@gmail.com> --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
…ic context to parse using mapper (ethereum#1396) * feat(clis,exceptions,specs): Pydantic validation using exception mapper * fix(specs): Skip block exception check on requests modifications * fix(docs): Links * fix(tests): EIP-4844: mark block as skip block exception verification * refactor(exceptions): Mapper mappings allow regex, convert from `property` to `ClassVar` * fix(docs): tox * chore(deps): remove now unused bdict dependency * Suggestions for ethereum#1396, refactor(exceptions,specs): Support general block exceptions - Pydantic context to parse using mapper (ethereum#1404) * refactor(fw): use enum helper; rename `ty` to `execution_context` * refactor(fw): use more specific names for exception classes * fix(tests): Add comment explaining `skip_exception_verification` * feat(clis): Add `reliable` flag to exception mapper class * fix: tests * fix(specs,clis,tools): Use `default_t8n` and remove `run_in_serial` from most unit tests * fix(specs): Bug and variable names * fix: bug * feat(clis/evmone): Add insufficient-blob-fee error * fix(tests): Allow similar blob exceptions * Apply suggestions from code review Co-authored-by: danceratopz <danceratopz@gmail.com> --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Couple of suggestions for
src/ethereum_test_specs/helpers.pyin #1396:tytoexecution_context.🔗 Related Issues
#1396