new(tests): add more test cases for request types #1340

felix314159 · 2025-03-21T17:09:47Z

🗒️ Description

WIP

🔗 Related Issues

✅ Checklist

All: Set appropriate labels for the changes.
All: Considered squashing commits to improve commit history.
All: Added an entry to CHANGELOG.md.
All: Considered updating the online docs in the ./docs/ directory.
Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

…valid_deposit_withdrawal_consolidation_requests

marioevz

Some comments on this preliminary review 🙌

Let me know if any of them needs more info.

tests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py

…_requests.py

… added mypy silencer for type warning

…lows 18 withdrawals per block

marioevz

I mainly reviewed test_modified_withdrawal_contract.py here, but some thoughts:

I would use --traces when running uv run fill to make sure that the transactions are indeed correctly calling the system contract and are not failing or running out of gas.
My main concern with the modified contract is that it will be a bit difficult to debug if the system call is not working correctly because currently the t8n does not provide traces for the system call (although that would be a nice feature!).

If you have the modified sys-asm contract to take a look at we could also help out reviewing that 👍

tests/prague/eip7685_general_purpose_el_requests/test_modified_withdrawal_contract.py

marioevz

Hey, I addressed your questions in each comment, it works for me locally although I didn't check for 18 withdrawals only two.

tests/prague/eip7002_el_triggerable_withdrawals/helpers.py

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py

marioevz

Some comments that I think will help in this and future tests where you have to put bytes into memory 👍

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py

marioevz

Some comments, but I think it's close to be good to go 👍

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py

tests/prague/eip7685_general_purpose_el_requests/test_multi_type_requests.py

…withdrawal_contract.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

marioevz

One last request, please add a item to docs/CHANGELOG.md with a one-line description of the tests added by this PR.

Thanks for the changes!

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py

…#1340) * new(tests): added more cases (two contract req, one EOA req) in test_valid_deposit_withdrawal_consolidation_requests * fixed comments * rename test_deposits_withdrawals_consolidations.py to test_multi_type_requests.py * changed type from ParameterSet to a union of the three request types, added mypy silencer for type warning * added draft test of trying out a modified withdrawal contract that allows 18 withdrawals per block * fixed docstrings * tried to implement marios feedback * moved test to a better suited folder (eip7002) * parameterized test and bugfixes * added pseudo contract that just returns withdrawals requests * removed unnecessary offset update * macro MSTORE now used instead of manually splitting into chunks * Update tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py * Datatype is ParameterSet Co-authored-by: Mario Vega <marioevz@gmail.com> * added pytest marker for prague, and some minor fixes * removed comment and updated CHANGELOG.md --------- Co-authored-by: Mario Vega <marioevz@gmail.com>

new(tests): added more cases (two contract req, one EOA req) in test_…

a7d548e

…valid_deposit_withdrawal_consolidation_requests

marioevz reviewed Mar 21, 2025

View reviewed changes

felix314159 added 4 commits March 24, 2025 09:55

fixed comments

f67fbb2

rename test_deposits_withdrawals_consolidations.py to test_multi_type…

e22fe91

…_requests.py

changed type from ParameterSet to a union of the three request types,…

4310e6c

… added mypy silencer for type warning

added draft test of trying out a modified withdrawal contract that al…

fb157d6

…lows 18 withdrawals per block

marioevz reviewed Mar 25, 2025

View reviewed changes

felix314159 added 3 commits March 25, 2025 15:40

fixed docstrings

4c48495

tried to implement marios feedback

c0f885d

moved test to a better suited folder (eip7002)

b61fe3e

felix314159 force-pushed the eip-7685-testcases-added branch from 4f602a2 to b61fe3e Compare March 25, 2025 16:37

marioevz reviewed Mar 25, 2025

View reviewed changes

felix314159 added 3 commits March 26, 2025 09:22

parameterized test and bugfixes

d2519c4

added pseudo contract that just returns withdrawals requests

e9a5740

removed unnecessary offset update

c1e9fc9

felix314159 force-pushed the eip-7685-testcases-added branch from 995c2af to c1e9fc9 Compare March 28, 2025 13:08

marioevz reviewed Mar 28, 2025

View reviewed changes

macro MSTORE now used instead of manually splitting into chunks

85ac1ff

felix314159 commented Mar 31, 2025

View reviewed changes

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py Outdated Show resolved Hide resolved

marioevz reviewed Mar 31, 2025

View reviewed changes

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py Outdated Show resolved Hide resolved

marioevz reviewed Mar 31, 2025

View reviewed changes

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py Show resolved Hide resolved

marioevz reviewed Mar 31, 2025

View reviewed changes

tests/prague/eip7685_general_purpose_el_requests/test_multi_type_requests.py Outdated Show resolved Hide resolved

marioevz reviewed Mar 31, 2025

View reviewed changes

tests/prague/eip7685_general_purpose_el_requests/test_multi_type_requests.py Outdated Show resolved Hide resolved

marioevz and others added 3 commits April 1, 2025 08:14

Update tests/prague/eip7002_el_triggerable_withdrawals/test_modified_…

1d5b358

…withdrawal_contract.py

Datatype is ParameterSet

0ceffe2

Co-authored-by: Mario Vega <marioevz@gmail.com>

added pytest marker for prague, and some minor fixes

10f41b0

felix314159 force-pushed the eip-7685-testcases-added branch from f66372c to 10f41b0 Compare April 1, 2025 08:29

marioevz approved these changes Apr 1, 2025

View reviewed changes

tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py Outdated Show resolved Hide resolved

removed comment and updated CHANGELOG.md

8c3adbd

danceratopz mentioned this pull request Apr 2, 2025

chore(tests): review prague test cases #1299

Closed

33 tasks

spencer-tb mentioned this pull request Apr 2, 2025

feat(release): tasks for version v4.2.0 #1383

Closed

11 tasks

marioevz merged commit 0fc6bd8 into ethereum:main Apr 2, 2025
11 checks passed

marioevz mentioned this pull request Sep 29, 2025

Add Felix Hoffmann protocolguild/documentation#406

Merged

new(tests): add more test cases for request types #1340

new(tests): add more test cases for request types #1340

Uh oh!

Conversation

felix314159 commented Mar 21, 2025

🗒️ Description

🔗 Related Issues

✅ Checklist

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants