-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eth_simulateV1
#484
Open
KillariDev
wants to merge
36
commits into
ethereum:main
Choose a base branch
from
DarkFlorist:eth_multicallv1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add eth_simulateV1
#484
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
31fcbe5
eth_multicallv1
KillariDev 8b020ce
fix some issues with the spec
KillariDev aaab3f8
Merge remote-tracking branch 'upstream/main' into eth_multicallv1
KillariDev 8ab6539
fix refs, fix styling
KillariDev 61fb231
Update docs/multicall-notes.md
KillariDev 45313dd
Update docs/multicall-notes.md
KillariDev d9411e0
feedback according to comments, and a 30mb limit
KillariDev 06d27bd
Merge branch 'eth_multicallv1' of https://github.com/DarkFlorist/exec…
KillariDev b4ce098
use 0xee.. address instead of 0x0 address for eth transfer logs
KillariDev 0043e12
add withdrawals to input and output
KillariDev 3095c08
add support for EIP-4844
KillariDev c7ec336
rename eth_multicallV1 to eth_simulateV1
KillariDev c20052c
update according to meeting (nonce calculation, blobBaseFee, gasLimit…
KillariDev 7aee5b3
add note that when targeting non-precompiles with MovePrecompileToAdd…
KillariDev 8996847
rename focument to be eth simulate related because of the name change
KillariDev e76cb57
add transaction hash and index to the logs
KillariDev dde3124
Update docs/ethsimulatev1-notes.md
KillariDev db721c4
fix blobgasPrices
KillariDev aef37eb
use blobBaseFee for now
KillariDev 85ad1a4
remove blobBaseFee, not part of header
KillariDev 21c6dfa
blobBaseFee to uint64 and validator_index -> `validatorIndex`
KillariDev e27cf9a
Merge remote-tracking branch 'upstream/main' into eth_multicallv1
KillariDev b597a7f
Merge remote-tracking branch 'upstream/main' into eth_multicallv1
KillariDev 1ccfd37
remove phantom blocks :(
KillariDev f297b4f
rename multicall stuff to ethsimulate stuff. Add `returnFullTransacti…
KillariDev e3332ea
use `allOf`
KillariDev e913466
when validation mode is false, baseFeePerGas and blobBaseFee are set…
KillariDev 8141886
multicall -> eth_simulate, add chain id, add default rsv values, add…
KillariDev 2ee9fc2
add rationale for pre-computed calls
s1na 42d1249
update with flexibility
s1na 55f657c
Merge pull request #3 from s1na/eth_multicallv1
KillariDev 0256a4b
added removed field to logs which should have been there
KillariDev de3e3f5
make "removed" an optional field
KillariDev d7b4616
relax time requirement so that time can stay still
KillariDev 3324ce9
increase timestamp by +12 (on mainnet) instead of +1
KillariDev e56d320
Update docs/ethsimulatev1-notes.md
KillariDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also argue that there is a max number, because if one allows to create only one block, then one can still request block very high number and this would impose a lot of phantom block hashings.