Skip to content

Engine API: validate blob versioned hashes #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2023
Merged

Engine API: validate blob versioned hashes #407

merged 5 commits into from
May 24, 2023

Conversation

mkalinin
Copy link
Contributor

Adds blob versioned hashes as a second parameter to engine_newPayloadV3 as a follow up to ethereum/consensus-specs#3345 (comment)

Co-authored-by: g11tech <develop@g11tech.io>
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here 👍

@mkalinin mkalinin marked this pull request as ready for review May 17, 2023 11:55
@mkalinin
Copy link
Contributor Author

More detailed steps to validate blob versioned hashes are added, with the requirement to run this check instantly disregarding the sync process, i.e. in the same way as block hash is validated today.

This PR adds a second parameter to the newPayloadV3. An alternative is to add new ExecutionPayloadRequestV1 container and pass a payload and an expected array of blob hashes inside of this object. I would like to double check that client devs are fine with adding a second parameter vs adding a new container.

Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@mkalinin mkalinin merged commit 128af69 into main May 24, 2023
@realbigsean realbigsean mentioned this pull request Jun 5, 2023
8 tasks
tersec added a commit to status-im/nim-web3 that referenced this pull request Jun 9, 2023
tersec added a commit to status-im/nim-web3 that referenced this pull request Jun 9, 2023
@mkalinin mkalinin deleted the mkalinin-patch-8 branch September 14, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants