Revert block hash object #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just stumbled upon this while looking into https://eips.ethereum.org/EIPS/eip-1898. I thought I'd add that the EIP explicitly allows for objects that look like: And here's where Geth supports this: https://github.com/ethereum/go-ethereum/blob/452a12aa7903209713ccdc54af65a1a31e73190d/rpc/types.go#L147-L156. What the EIP does not explicitly specify (at least from my reading of it) is the ability to also pass in block hashes without a wrapper object like above, but it seems that the Geth team allowed this anyway here: https://github.com/ethereum/go-ethereum/blob/452a12aa7903209713ccdc54af65a1a31e73190d/rpc/types.go#L184-L192. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a change from #326 which turns block hashes into an object. I misunderstood this change and CI did not catch the issue in the tests.