Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eth_protocolVersion #264

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

lightclient
Copy link
Member

It doesn't appear to be a standard method and I'm not clear what "version" it would be returning.

@lightclient lightclient marked this pull request as ready for review July 21, 2022 23:19
@ralexstokes
Copy link
Member

I'd assume the devp2p version of the eth subproto but removing things is always good

@lightclient lightclient merged commit b4051c2 into ethereum:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants