Refactor system_call()
#976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #976 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 143 144 +1
Lines 16149 16155 +6
=======================================
+ Hits 15228 15234 +6
Misses 921 921
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
state/system_contracts_refactor
branch
from
25d220b
to
a94a3ec
Compare
pdobacz
approved these changes
Aug 20, 2024
gumb0
reviewed
Aug 21, 2024
| @@ -0,0 +1,74 @@ | |||
| // evmone: Fast Ethereum Virtual Machine implementation | |||
| // Copyright 2023 The evmone Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2023 The evmone Authors. | |
| // Copyright 2024 The evmone Authors. |
There was a problem hiding this comment.
2023 is the year then this code was introduced.
gumb0
approved these changes
Aug 21, 2024
Refactor and abstract the `system_call()` to make adding new system contracts easier. Make address of system contracts public.
chfast
force-pushed
the
state/system_contracts_refactor
branch
from
5fc2762
to
87a8918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and abstract the
system_call()to make adding new system contracts easier.