Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify eof.read_valid_eof1_header test by using bytecode utility #796

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jan 16, 2024

No description provided.

@gumb0 gumb0 requested review from hugo-dc and chfast January 16, 2024 16:43
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (639f204) 97.91% compared to head (68b51e3) 97.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   97.91%   97.90%   -0.01%     
==========================================
  Files         110      110              
  Lines       10581    10573       -8     
==========================================
- Hits        10360    10352       -8     
  Misses        221      221              
Flag Coverage Δ
blockchaintests 60.23% <ø> (ø)
statetests 62.17% <ø> (ø)
statetests-silkpre 26.00% <0.00%> (+<0.01%) ⬆️
unittests 95.87% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/unittests/eof_test.cpp 93.33% <100.00%> (-1.41%) ⬇️

@gumb0 gumb0 merged commit b74b9db into master Jan 17, 2024
25 checks passed
@gumb0 gumb0 deleted the test/simplify-read-eof-test branch January 17, 2024 10:39
@gumb0 gumb0 mentioned this pull request Jan 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants