state: Move pieces of State implemetation #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 110 110
Lines 10577 10580 +3
=======================================
+ Hits 10356 10359 +3
Misses 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
state/impl_move_to_cpp
branch
2 times, most recently
from
0c3fb24 to
26c81ee
Compare
rodiazet
reviewed
Jan 9, 2024
| { | ||
| address addr; | ||
| }; | ||
| struct JournalBase |
There was a problem hiding this comment.
Would be good to have some doc comments for base and deriving structs, but I can live w/o it.
There was a problem hiding this comment.
This is going to be updated later.
|
Can we also add a motivation of this change. |
rodiazet
approved these changes
Jan 9, 2024
Added:
|
This avoids heavy rebuilds when these implementations are modified.
These are internal State types visible in the header file only because of C++ limitations.
chfast
force-pushed
the
state/impl_move_to_cpp
branch
from
26c81ee to
e44aebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollback()(onlytouch()for now). We later want to hide the journal from users by providing revertible state modification methods.Statemethods implementations to thestate.cppfile. This hides the implementation and allows faster builds.class Statescope.