Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust bindings generation #707

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix rust bindings generation #707

merged 1 commit into from
Mar 15, 2024

Conversation

iamyulong
Copy link
Contributor

Description

This PR fixes two issues with the rust bindings:

  • Constant EMVC_ABI_VERSION is not exported, caused by an outdated bindgen
  • Enums are not properly rustified, due to invalid configuration.

Testing

I've run cargo test for the whole workspace and cargo build for the example-rust-vm.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (f89284f) to head (544fece).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          25       25           
  Lines        3861     3861           
  Branches      396      396           
=======================================
  Hits         3610     3610           
  Misses        139      139           
  Partials      112      112           

@chfast
Copy link
Member

chfast commented Mar 14, 2024

Oh great. This explains why I'm also seeing this problems locally...

@chfast chfast requested a review from axic March 14, 2024 18:56
@chfast chfast merged commit 954944a into ethereum:master Mar 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants