Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Conversion {address, bytes32} → bytes_view #636

Merged
merged 1 commit into from
May 6, 2022
Merged

C++: Conversion {address, bytes32} → bytes_view #636

merged 1 commit into from
May 6, 2022

Conversation

chfast
Copy link
Member

@chfast chfast commented May 6, 2022

This change allows passing address and bytes32 objects to functions taking bytes_view as argument.

axic
axic requested changes May 6, 2022
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@chfast chfast force-pushed the cpp_bytes_view branch 2 times, most recently from ed16827 to e9ae8db Compare May 6, 2022 09:39
@chfast chfast requested a review from yperbasis May 6, 2022 09:49
@chfast
Copy link
Member Author

chfast commented May 6, 2022

Can you add a test?

Added.

@chfast chfast merged commit 975b52a into master May 6, 2022
@chfast chfast deleted the cpp_bytes_view branch May 6, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@yperbasis yperbasis Awaiting requested review from yperbasis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic