Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result Optional Storage #59

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Result Optional Storage #59

merged 2 commits into from
Aug 20, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 13, 2018

Move Result Optional Storage to it's own group in EVMC Helpers.
See documentation: https://636-66214407-gh.circle-artifacts.com/0/docs/index.html.

@chfast chfast force-pushed the optional_storage branch 2 times, most recently from 8370b8c to 9dffef7 Compare August 13, 2018 21:30
@chfast chfast requested review from gumb0 and axic August 14, 2018 10:24
Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are a disctinct separate group, it might make sense to move them to separate header, otherwise looks good to me.

* Helpers for optional storage of evmc_result.
*
* In some contexts (i.e. evmc_result::create_address is unused) objects of
* type evmc_result contains a memory storage that MAY be uses by the object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses -> used

@chfast chfast merged commit c18463b into master Aug 20, 2018
@chfast chfast deleted the optional_storage branch August 20, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants