Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ChainID width to 64 bit #420

Closed
wants to merge 2 commits into from
Closed

Change ChainID width to 64 bit #420

wants to merge 2 commits into from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 9, 2019

@gumb0 gumb0 force-pushed the chainid-64bit branch 2 times, most recently from a449f21 to 291efa7 Compare September 9, 2019 11:30
@chfast chfast added the changelog Deserves a CHANGELOG entry label Sep 13, 2019
@chfast chfast self-requested a review September 13, 2019 12:11
@gumb0
Copy link
Member Author

gumb0 commented Sep 16, 2019

Rebased.

@gumb0 gumb0 mentioned this pull request Sep 18, 2019
Closed
@chfast
Copy link
Member

chfast commented Sep 30, 2019

Can this be closed now?

@gumb0
Copy link
Member Author

gumb0 commented Sep 30, 2019

Well there's a separate EIP for this now ethereum/EIPs#2294

It might or might not be included in Berlin 🤷‍♂️

@chfast
Copy link
Member

chfast commented Nov 1, 2019

Can we close this now? The 256-bit variant is the current EIP spec.

@axic
Copy link
Member

axic commented Nov 1, 2019

We actually still want to apply this through EIP-1985.

@chfast
Copy link
Member

chfast commented Nov 1, 2019

We actually still want to apply this through EIP-1985.

Right, but the change is trivial. I don't think it's worth to keep the PR open. But we can still link to it from the EIP.

@chfast chfast closed this Nov 13, 2019
@axic axic deleted the chainid-64bit branch November 13, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast Awaiting requested review from chfast

Assignees
No one assigned
Labels
changelog Deserves a CHANGELOG entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gumb0 @chfast @axic