Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cable to 0.4.4 #405

Merged
merged 3 commits into from
Aug 16, 2019
Merged

Upgrade Cable to 0.4.4 #405

merged 3 commits into from
Aug 16, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 16, 2019

Fixes CMake issue in ewasm/hera#550.

3fb12ab Cable 0.4.4
680296e Fix Cable modules not being in CMAKE_MODULE_PATH

git-subtree-dir: cmake/cable
git-subtree-split: 3fb12ab54d42ecebeedd399f9146f88b1f8fdcbc
@chfast chfast requested a review from axic August 16, 2019 21:35
@chfast chfast changed the title Cable Upgrade Cable to 0.4.4 Aug 16, 2019
@axic
Copy link
Member

axic commented Aug 16, 2019

Apparently this isn't the solution. Hera throws this:

CMake Error at cmake/cable/CableBuildType.cmake:14 (message):
  cable_set_build_type() can be used before project()
Call Stack (most recent call first):
  CMakeLists.txt:24 (cable_set_build_type)

If I move cable_set_build_type prior to project then it works, so I guess it is an okay enough work around.

@chfast
Copy link
Member Author

chfast commented Aug 16, 2019

Apparently this isn't the solution. Hera throws this:

CMake Error at cmake/cable/CableBuildType.cmake:14 (message):
  cable_set_build_type() can be used before project()
Call Stack (most recent call first):
  CMakeLists.txt:24 (cable_set_build_type)

If I move cable_set_build_type prior to project then it works, so I guess it is an okay enough work around.

Works for me. Are you sure you have not upgraded Cable in Hera?

@axic
Copy link
Member

axic commented Aug 16, 2019

Are you sure you have not upgraded Cable in Hera?

It seems I did change it locally. Did a fresh checkout and now it works.

@chfast
Copy link
Member Author

chfast commented Aug 16, 2019

It seems I did change it locally. Did a fresh checkout and now it works.

I pushed it to ewasm/hera#550 to check.

@chfast chfast merged commit 799b8ff into release/6.3 Aug 16, 2019
@chfast chfast deleted the cable branch August 16, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants