This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Feature/db upgrade #986
Merged
Feature/db upgrade #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parsedRlp. Create a new method makeRlp() that reconstructs and returns an rlp from a parsedRlp LList object. Add (parsedRlp != null) case to the if (!dirty) section of the encode method. Note that the newly created rlp length may be >= 32, so it may need to be saved and returned as a hash. The last section of the else clause handles saving a new rlp. Move this section of code out of the else clause so it can handle a new rlp from either the if or else clause.
(cherry picked from commit 77a01b0)
- NodeFilterTest's acceptNullIpPatternAsCatchAllForNodes and doNotAcceptNullIpPatternAsCatchAllForInetAddresses seem to indicate a discrepancy between InetAddress and Node acceptance. Smells like a potential bug. - NodeFilterTest's acceptInvalidNodeHostnameWhenUsingWildcard and doNotAcceptInvalidNodeHostnameWhenUsingPattern seem to indicate a discrepancy in acceptance logic. Smells like a potential bug. - SystemPropertiesTest's testExposeBugWhereNonHexEncodedIsAcceptedWithoutValidation seems to indicate that private key validation is not correct.
- EIP-706 provides snappy samples. FrameCodec should be able to decode these samples.
Fix word misspelled: thisLenght -> thisLength
remove broken blog link
zilm13
reviewed
Dec 25, 2017
| @@ -203,6 +203,7 @@ database { | |||
| # controls how much last block states are not pruned | |||
| # it is not recommneded to set this value below 192 | |||
| # as it can prevent rebranching from long fork chains | |||
| # consider enlarging cache.pruneWindowCacheSize if you want to increase maxDepth | |||
There was a problem hiding this comment.
property is pruneCacheSize
zilm13
reviewed
Dec 25, 2017
| # maximum size (in Mb) the state bloom fiter can grow up to | ||
| # when reaching this threshold the bloom filter | ||
| # is turned off forever | ||
| # 128M can manage approx up to 50M of db entries | ||
| # deprecated, states source is no more backed with bloom filter |
There was a problem hiding this comment.
may be capitalize DEPRECATED or smth like this, looks like a wall of text
same for the next "deprecated" note
zilm13
reviewed
Dec 25, 2017
| import org.ethereum.datasource.ObjectDataSource; | ||
| import org.ethereum.datasource.Serializer; | ||
| import org.ethereum.datasource.Source; | ||
| import org.ethereum.datasource.*; |
There was a problem hiding this comment.
imports: LevelDbDataSource unused
do we use * imports?
zilm13
reviewed
Dec 25, 2017
| @@ -22,6 +22,7 @@ | |||
| import org.ethereum.datasource.*; | |||
| import org.ethereum.trie.*; | |||
| import org.ethereum.vm.DataWord; | |||
| import org.spongycastle.util.encoders.Hex; | |||
zilm13
reviewed
Dec 25, 2017
| @RunWith(SpringJUnit4ClassRunner.class) | ||
| @ContextConfiguration(loader = AnnotationConfigContextLoader.class) | ||
| @NoAutoscan | ||
| @Ignore |
There was a problem hiding this comment.
Why ignored? It's not very long
There was a problem hiding this comment.
Decided to create similar integration test which uses memory instead of disk and don't need whole context to be involved
…indows DLL (works starting from SSE4.2 CPU architecture and Win Vista)
…nto feature/db-upgrade
This change fixes bulk test run issue which is somehow related to incorrect blockchain config. Only bulk run was affected by this problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.