[WIP] State transition #1177
Merged
[WIP] State transition #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
reviewed
Sep 12, 2018
| } | ||
|
|
||
| @Override | ||
| public synchronized Validator get(Integer index) { |
There was a problem hiding this comment.
Is it enough for this structure to have only get by index №?
There was a problem hiding this comment.
It might be not in the future, but for now let's keep it simple
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
I'd add smth with 0's omit
There was a problem hiding this comment.
without 0x prefix?
There was a problem hiding this comment.
No, I mean odd hex symbols for example. To test it's passing through hex helper you've added correctly
|
Looks like it is ready for merge. @zilm13 please, approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet not ready for merge, as always :)
ToDo:
Resolves #1143