migrate local-environment page to Chakra
#9583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
|
@pettinarip What should be done with the commented codes? |
✅ ethereum-org-website-dev deploy preview ready
|
Yes please, lets remove those commented components, imports, and jsx 🙏🏼 they were commented 2 years ago xD |
pettinarip
requested changes
Mar 2, 2023
| // Intro, | ||
| Page, | ||
| // InfoBanner, | ||
| } from "../../components/SharedStyledComponents" |
There was a problem hiding this comment.
As a quick review, one thing we want to deprecate is the usage of SharedStyledComponents. We need to replace those components with Chakra components.
There was a problem hiding this comment.
Nice! no need to say sorry. Thank you for the great work!
…h Chakra components
38 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
local-environmentpage to ChakraRelated Issue
#9353