Migrate BugBountyCards component to chakra UI [Relates to #6374] #8739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are relying on the default breakpoints, which differ from the previous one used for the CardRow styles, I increased the flex-basis in small devices to keep the layout breaks consistent with the previous implementation.
Box shadow seems to not support color tokens yet and, therefore, the only way to reuse styles is to directly call the CSS properties defined in our theme. This is an acceptable hack from my point of view but I'm open to reconsider it in further discussions.
Marcelixoo
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
Marcelixoo
changed the title
✅ ethereum-org-website-dev deploy preview ready
|
|
FYI, I've checked the deployment preview and it looks pretty solid there as well 👍🏼 |
pettinarip
requested changes
Dec 5, 2022
There was a problem hiding this comment.
Looks great overall, nice job @Marcelixoo. I've left a few minor comments.
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
pettinarip
approved these changes
Dec 22, 2022
|
Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳! |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@all-contributors please add @Marcelixoo for code |
|
I've put up a pull request to add @Marcelixoo! 🎉 |
80 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the BugBountyCards component using ChakraUI.
Below you can find screenshots of the component rendered before/after the changes side-by-side and in different states.
Dark mode: Large screens
Current versions
ion
After changes
Light mode: Large screens
Current version
After changes
Light mode: Medium screens
Current version
After changes
Light mode: Small screens
Current version
After changes
Related Issue
#6374