Migrate Layer2ProductCard to Chakra #8007
Conversation
ImMiguelP
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
src/components/Layer2ProductCard.tsx
Outdated
| className="hover" | ||
| > | ||
| <Box> | ||
| <Heading as="h3" mt="0" mb={3}> |
There was a problem hiding this comment.
this heading seems too big comparing it with the prod version
There was a problem hiding this comment.
So it seems chakra sizing for h3 "lg" is bigger than the sizing y'all are using. I messed around with the font size and used "24px" but when the screen size resolution goes to phone the font is smaller than what is being used in the prod version. The closest I got to it looking to the prod version is using size="md".
There was a problem hiding this comment.
Oh ok, good point. Lets use 3xl instead of md that is slightly smaller than the one we were using here (which was 2rem).
There was a problem hiding this comment.
Hi are we sure we want to use 3xl here? This will just make the heading even more bigger than what it originally had (lg)? If so I will happily do so just making sure this is what we going for based on styling.
Here is a screenshot to showcase the heading with 3xl instead of md
There was a problem hiding this comment.
So, on the preview deploy I see this:
and this is production:
Production is using 24px and the preview 20px.
24px = 1.5rem = 2xl in the chakra scale
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
2 participants
Description
Migrates
Layer2ProductCardcomponent fromemotiontochakra-uiRelated Issue
#6374