-
Notifications
You must be signed in to change notification settings - Fork 5.2k
refactor(code-modal): use chakra modal with custom variant #8006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
export interface IProps { | ||
children?: React.ReactNode | ||
className?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the className
property because it wasn't used anywhere
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LuisUrrutia this is great! awesome work defining the new variant.
I've left a couple of questions and a few minor changes.
Internal: retriggered a rebuild and it was successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @LuisUrrutia thanks for the work on this PR 💪🏼
Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
@all-contributors please add @LuisUrrutia for code |
I've put up a pull request to add @LuisUrrutia! 🎉 |
Description
Migrates
CodeModal
component fromemotion
tochakra-ui
.Related Issue
#6374