Skip to content

Conversation

LuisUrrutia
Copy link
Contributor

@LuisUrrutia LuisUrrutia commented Sep 24, 2022

Description

Migrates CodeModal component from emotion to chakra-ui.

To do this change, I had to use the modal component from chakra-ui and adjust the zIndex of portals to 1001 (by default, it's 40) because the modal overlay was behind the header of the website (z-index: 1000).

The result's pretty close to the original, but it has some little differences (really minimal) to preserve most of the default values of chakra.

Related Issue

#6374


export interface IProps {
children?: React.ReactNode
className?: string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the className property because it wasn't used anywhere

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 24, 2022

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LuisUrrutia this is great! awesome work defining the new variant.

I've left a couple of questions and a few minor changes.

@pettinarip
Copy link
Member

pettinarip commented Sep 28, 2022

Internal: retriggered a rebuild and it was successful

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @LuisUrrutia thanks for the work on this PR 💪🏼

Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!

@pettinarip pettinarip merged commit e566f79 into ethereum:dev Sep 28, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 28, 2022

Woohoo, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:
GitPOAP: 2022 Ethereum.org Contributor GitPOAP Badge

Head on over to GitPOAP.io and connect your GitHub account to mint!

@pettinarip
Copy link
Member

@all-contributors please add @LuisUrrutia for code

@allcontributors
Copy link
Contributor

@pettinarip

I've put up a pull request to add @LuisUrrutia! 🎉

@pettinarip pettinarip mentioned this pull request Sep 28, 2022
80 tasks
@corwintines corwintines mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants