Skip to content

Migrate InfoBanner to Chakra #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2022
Merged

Migrate InfoBanner to Chakra #7929

merged 4 commits into from
Sep 23, 2022

Conversation

ImMiguelP
Copy link
Contributor

Description

  • Migrates InfoBanner component from emotion to chakra-ui

Related Issue

#6374

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 20, 2022 •
edited
Loading

✅ ethereum-org-website-dev deploy preview ready

pettinarip
pettinarip requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @ImMiguelP left a few comments. Thanks for the PR

@ImMiguelP
Copy link
Contributor Author

Looking good @ImMiguelP left a few comments. Thanks for the PR

Thank you @pettinarip here goes the updated files with the correct changes

pettinarip
pettinarip approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @ImMiguelP! Thanks for the PR!

Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!

@pettinarip pettinarip merged commit 656205f into ethereum:dev Sep 23, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 23, 2022

Woohoo, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:
GitPOAP: 2022 Ethereum.org Contributor GitPOAP Badge

Head on over to GitPOAP.io and connect your GitHub account to mint!

@pettinarip
Copy link
Member

@all-contributors please add @ImMiguelP for code

@allcontributors allcontributors bot mentioned this pull request Sep 23, 2022
Merged
@allcontributors
Copy link
Contributor

@pettinarip

I've put up a pull request to add @ImMiguelP! 🎉

@pettinarip pettinarip mentioned this pull request Sep 23, 2022
Closed
80 tasks
@corwintines corwintines mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pettinarip pettinarip pettinarip approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees

No one assigned

Labels

archived: chakra-migration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ImMiguelP @pettinarip