Refactor HorizontalCard for Chakra UI #7893
Conversation
ameeetgaikwad
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
For some reason, this version doesn't look the same as in prod. Check the following examples. They are from https://ethereum.org/en/stablecoins/
this PR version:
prod:
I encourage you to try to see where the issue is. If not, later I'll try to debug it myself.
|
@pettinarip not able to find it :( |
src/components/HorizontalCard.tsx
Outdated
| <Description>{description}</Description> | ||
| <Flex borderRadius="base" className={className}> | ||
| <Emoji fontSize={`${emojiSize}rem`} text={emoji} /> | ||
| <Flex grow="0" shrink="1" basis="75%" ml="8"> |
There was a problem hiding this comment.
@ameeetgaikwad and @pettinarip: Your culprit is this Flex component, when it should just be a Box. You will need to reword the other props.
<Box flexGrow='0' flexShrink='1' flexBasis='75%' ml="8">There was a problem hiding this comment.
I'll work on that
There was a problem hiding this comment.
Thanks, @ameeetgaikwad and @TylerAPfledderer. Will circle back in a couple of days
There was a problem hiding this comment.
@pettinarip @corwintines check this out! I've done the required changes
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@ameeetgaikwad be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳! |
|
@all-contributors please add @ameeetgaikwad for code |
|
I've put up a pull request to add @ameeetgaikwad! 🎉 |
|
I've put up a pull request to add @jakebolam! 🎉 |
|
I've put up a pull request to add @ameeetgaikwad! 🎉 |
4 participants
Description
Refactored
HorizontalCardcomponent for Chakra UI.