Skip to content

Refactor YouTube component to use ChakraUI #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Refactor YouTube component to use ChakraUI #7723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ec932
Refactor YouTube component to use ChakraUI
minimalsm Sep 6, 2022
969505a
Update src/components/YouTube.tsx
minimalsm Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/components/YouTube.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
import React from "react"
import styled from "@emotion/styled"

const Figure = styled.figure`
display: block;
margin: 1rem 0;
`
import { Box } from "@chakra-ui/react"

/**
* @param {id} ID of the YouTube video
Expand All @@ -27,7 +22,7 @@ const YouTube: React.FC<IProps> = ({ id, start = "0", title = "YouTube" }) => {
const baseUrl = "https://www.youtube.com/embed/"
const src = baseUrl + id + startQuery
return (
<Figure>
<Box as="figure" display="block" my={4}>
<iframe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'd want to refactor the iframe to Chakra. LMK if you disagree

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thats ok 👍🏼

width="100%"
height="315"
Expand All @@ -43,7 +38,7 @@ const YouTube: React.FC<IProps> = ({ id, start = "0", title = "YouTube" }) => {
picture-in-picture"
allowFullScreen
></iframe>
</Figure>
</Box>
)
}

Expand Down