Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tutorial content filtering by tag [Fixes #5444] #5445

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

chelorope
Copy link
Contributor

Issue: #5444

Description

On the Tutorials page
When more than one tag is selected and one of these tags is removed, the tutorials aren't filtered again

Steps to reproduce:

  • Navigate to the tutorials page
  • Select more than one tag
  • See the filtered tutorials that match those tags
  • Deselect only one of the selected filters
  • See how the filtered tutorials haven't been recalculated

@chelorope chelorope changed the title Fixes tutorial content filtering by tag [#5444] Fixes tutorial content filtering by tag [Fixes #5444] Feb 18, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 18, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 11m

Performance

Lighthouse report

Metric Score
Performance 🔶 23
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @chelorope! Thanks!

@corwintines
Copy link
Member

@all-contributors can you add @chelorope for code

@allcontributors
Copy link
Contributor

@corwintines

I've put up a pull request to add @chelorope! 🎉

@corwintines
Copy link
Member

@chelorope make sure to come claim your POAP in the ethereum.com discord :)

https://discord.gg/zCHhRAgQ

@corwintines corwintines merged commit 0bc6fe1 into ethereum:dev Feb 19, 2022
@corwintines corwintines mentioned this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants