-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placeholder avatar to prevent layout jumping [Fixes #2809] #2989
Conversation
@hueyhe Hey, thanks for doing this! Was just looking at it, seems to work pretty well. I'll defer to @ryancreatescopy on styling comments, then I'll be happy to double check the code and bring this in 👍🏻 |
@ryancreatescopy OK. I'll work on that. |
@ryancreatescopy I've updated the skeleton style and added a transition from the loading state to loaded state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hueyhe I like how this is coming along! Noticed this causes a bug on mobile though, mind taking a look at that?
May just be a matter of hiding the contributors button until loading is done.
@wackerow I've fixed the bug on mobile. Please comment if there's any other problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hueyhe lookin good! Thanks for being patient, pulling in now =)
@all-contributors please add @hueyhe for code |
I've put up a pull request to add @hueyhe! 🎉 |
Description
Add placeholder avatar to prevent layout jumping [Fixes #2809]