Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder avatar to prevent layout jumping [Fixes #2809] #2989

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Add placeholder avatar to prevent layout jumping [Fixes #2809] #2989

merged 3 commits into from
Jun 1, 2021

Conversation

hueyhe
Copy link
Contributor

@hueyhe hueyhe commented May 7, 2021

Description

Add placeholder avatar to prevent layout jumping [Fixes #2809]

@hueyhe hueyhe changed the title fix: add placeholder avatar to prevent layout jumping [Fixes #2809] Add placeholder avatar to prevent layout jumping [Fixes #2809] May 7, 2021
@wackerow
Copy link
Member

@hueyhe Hey, thanks for doing this! Was just looking at it, seems to work pretty well.

I'll defer to @ryancreatescopy on styling comments, then I'll be happy to double check the code and bring this in 👍🏻

@ryancreatescopy
Copy link
Contributor

I think it'd be cool if we had a loading state for text and button too. Maybe something like this super rough sketch:
image

could even add some kind of light animation to it to suggest it's loading, it looks a little jerky right now.

@hueyhe
Copy link
Contributor Author

hueyhe commented May 12, 2021

image

@ryancreatescopy OK. I'll work on that.

@hueyhe
Copy link
Contributor Author

hueyhe commented May 15, 2021

@ryancreatescopy I've updated the skeleton style and added a transition from the loading state to loaded state.
FYI, I'm not good at picking colors. The skeleton might look a bit bright in dark mode. Please tell me if you have any suggestion.

@wackerow
Copy link
Member

Added a commit using some of our theme colors instead, which respond to light and dark mode.
image
image

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@hueyhe I like how this is coming along! Noticed this causes a bug on mobile though, mind taking a look at that?
May just be a matter of hiding the contributors button until loading is done.

@hueyhe
Copy link
Contributor Author

hueyhe commented May 23, 2021

@wackerow I've fixed the bug on mobile. Please comment if there's any other problem.

@hueyhe hueyhe requested a review from wackerow May 24, 2021 08:27
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hueyhe lookin good! Thanks for being patient, pulling in now =)

@wackerow wackerow merged commit 1e8bb6d into ethereum:dev Jun 1, 2021
@wackerow
Copy link
Member

wackerow commented Jun 1, 2021

@all-contributors please add @hueyhe for code

@allcontributors
Copy link
Contributor

@wackerow

I've put up a pull request to add @hueyhe! 🎉

@wackerow wackerow mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No loading state for FileContributors components
3 participants