Skip to content

Translate metadata #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Translate metadata #2041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2d9e78
Translate dapps metadata
samajammin Dec 3, 2020
23596a2
Add dapps page og image
samajammin Dec 3, 2020
a90f071
v2.12.4
samajammin Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ethereum-org-website",
"version": "2.12.3",
"version": "2.12.4",
"description": "Website of ethereum.org",
"main": "index.js",
"repository": "git@github.com:ethereum/ethereum-org-website.git",
Expand Down
1 change: 1 addition & 0 deletions src/intl/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,6 +1301,7 @@
"page-get-eth-24-hrs": "(Last 24 hours)",
"transaction-fees": "transaction fees",
"page-dapps-title": "Decentralized applications (dapps)",
"page-dapps-desc": "Find an Ethereum application to try.",
"page-dapps-hero-header": "Ethereum-powered tools and services",
"page-dapps-hero-subtitle": "Dapps are a growing movement of applications that use Ethereum to disrupt business models or invent new ones.",
"page-dapps-what-are-dapps": "What are dapps?",
Expand Down
12 changes: 10 additions & 2 deletions src/pages-conditional/dapps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,8 +1042,9 @@ const DappsPage = ({ data }) => {
return (
<Page>
<PageMetadata
title="Decentralized applications (dapps)"
description="Find an Ethereum application to try."
title={translateMessageId("page-dapps-title", intl)}
description={translateMessageId("page-dapps-desc", intl)}
image={data.ogImage.childImageSharp.fixed.src}
/>
<Content>
<HeroContainer>
Expand Down Expand Up @@ -1601,6 +1602,13 @@ export const query = graphql`
}
}
}
ogImage: file(relativePath: { eq: "doge-computer.png" }) {
childImageSharp {
fixed(width: 1200) {
src
}
}
}
magicians: file(relativePath: { eq: "magicians.png" }) {
childImageSharp {
fluid(maxWidth: 300) {
Expand Down