Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public/content/developers/docs/gas/index.md #14934

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

AvulaRamSwaroop
Copy link
Contributor

At line 102:
Incorrect Formula For refund :
max fee - (base fee + tip)

Corrected Formula For refund:
(gas limit−gas used)×(maxfee−(base fee+tip))

Reason:
1.max fee - (base fee + tip) gives the per-unit refund, but the
actual refund depends on how much gas was unused.
2.gas unused = gas limit- gas used .

At line  102:
  Incorrect Formula For refund :
   max fee - (base fee + tip)

  Corrected Formula For refund: 
    (gas limit−gas used)×(maxfee−(base fee+tip))

  Reason: 
   1.max fee - (base fee + tip) gives the per-unit refund, but the 
    actual refund depends on how much gas was unused.
   2.gas unused = gas limit- gas used .
@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Feb 18, 2025
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7adb59b
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67b4e1c1c3d52d0008eb9622
😎 Deploy Preview https://deploy-preview-14934--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 46 (🔴 down 7 from production)
Accessibility: 95 (no change from production)
Best Practices: 89 (🔴 down 7 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow changed the title Update index.md Update public/content/developers/docs/gas/index.md Feb 18, 2025
@wackerow
Copy link
Member

Hey @AvulaRamSwaroop, thanks for the suggestion.. I see where you're coming from, just not sure this is really necessary? I think the calculation that is there is simple enough to read (in "per-unit" terms) and it gets the point across that the excess is returned. Feel free to push back; small change so not a hill I would die on

@AvulaRamSwaroop
Copy link
Contributor Author

AvulaRamSwaroop commented Feb 19, 2025

Hi ,As a beginner I felt little confused for a While cause the line is stated as :

any gas not used in a transaction is returned to the user (i.e. max fee - (base fee + tip) is returned).

So I later came to known that ,this must be multiplied by gas unused units .

if it is per-unit terms then no need to modify it .

Thanks for your Time.

@AvulaRamSwaroop
Copy link
Contributor Author

Hi @wackerow.Can I close this Issue ?

@Afeter8
Copy link

Afeter8 commented Feb 23, 2025

enterprise-eth(1).png

@Afeter8
Copy link

Afeter8 commented Mar 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants