Workdround for brave i18 redirection [Fixes #12027] #12056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiroyukiNaito
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
It is a quick solution by changing the language JSON object order. |
pettinarip
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Nice! its working for me, thanks @HiroyukiNaito
Lets wait for someone else to test it and we should be good to go.
wackerow
approved these changes
May 7, 2024
There was a problem hiding this comment.
Sorry for delay! Thanks @HiroyukiNaito, working great! So simple 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug report: Region-specific browser language preferences are being ignored #12027] is caused by only Brave browser specific i18 redirection.
Description
Only changing of the JSON array order can suppress the bug.
Related Issue
#12027