Pass message through to replaced exception #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
wolovim
force-pushed
the
replace-exception-with-message
branch
from
1220845 to
4840f06
Compare
wolovim
force-pushed
the
replace-exception-with-message
branch
from
4840f06 to
e7d5d4b
Compare
pipermerriam
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
replace_exceptiondecorator swallows the original exception context. This prevents web3.py from handling revert messages when using eth_tester. Relevant issue: ethereum/web3.py#1585.How was it fixed?
Just passes the
errthrough.To-Do
Cute Animal Picture