-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BIP32 HD account class. #24
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.68 ETH (406.11 USD @ $597.22/ETH) attached to it.
|
@dilatebrave please open the pull request as soon as you have any work ready. We have a loose policy of showing your work before the bounty being reserved for you. |
@pipermerriam - ok, i will open the pr asap, currently i dont have my pc |
@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done @dilatebrave due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done @dilatebrave due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Hi all - removed @dilatebrave from this issue, although he made good progress we didn't get this across. @pipermerriam are you still interested in having someone work on this? It now shows 'Open' on the Gitcoin Issue Explorer. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 5 months, 1 week ago. 1) sea212 has started work. Hello, I have seen that the last worker was dismissed. Is this position still open? Learn more on the Gitcoin Issue Details page. |
Great, we welcome the attempt, @sea212 ! |
@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
work on halt until saturday (maybe friday evening). This weekend I'll report the progress. |
Picked up work again. |
Good progress is made. #31 |
Work completed. Please check my last post in the WIP #31 and the results. @pipermerriam @carver @vs77bb |
@sea212 great work, really appreciate the consistent updates! Thanks for tagging @pipermerriam / @carver, they'll have to do review / merge as the next step for the bounty 🙂 |
@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Can you please give me any sign of life? I have completed this work 6 days ago and asked you to review it, no response. Now the bot begins to warn me. @pipermerriam @carver |
@sea212 Just snoozed the bot and pinged @carver on Gitter, expect something here soon. Apologies for silly @gitcoinbot 🙂 |
Thank you @vs77bb |
@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.68 ETH (143.12 USD @ $210.47/ETH) has been submitted by: @vs77bb please take a look at the submitted work:
|
Hey @sea212 sorry for the radio silence. Life has been quite busy lately. Looking now. |
Hey! No problem, I know how demanding it can get. Nevertheless, responding with just a tiny message like "I'll check it later, I'm very busy atm", if you have received my requests after all, would have greatly reduced my worries.
Thank you, this means a lot to me! |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 0.68 ETH (150.03 USD @ $220.63/ETH) attached to this issue has been approved & issued to @sea212.
|
Update default author email
Hi! Any updates? When it will be merged in master? |
cc @davesque |
Will try and get to this once some work is wrapped up on the blake2b project and a bit more progess has been made on the rust-vyper project. |
Closing with the merge of #87! |
What was wrong?
https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki
BIP32 specifies Hierarchical Deterministic Wallets. These are common ways to generate private keys.
How can it be fixed?
Implement a new account class
HDAccount
which exposes the same API (potentially via subclassing) asLocalAccount
, with additional APIs for generating child accounts.Test cases should include any public test vectors that are available as part of the spec.
The text was updated successfully, but these errors were encountered: