Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible aesthetic rework to get_domain #865

Merged
merged 8 commits into from
Apr 19, 2019
Merged

Possible aesthetic rework to get_domain #865

merged 8 commits into from
Apr 19, 2019

Commits on Mar 31, 2019

  1. Possible aesthetic rework to get_domain

    In general I dislike how domains, which should be an unobtrusive out-of-the-way thing that we don't think about much, are taking up so much space in code to express, to the point of them being the single thing preventing `bls_verify` from being expressed in one line of code. Here I reorder arguments and add a default, and make `bls_verify` a one-liner.
    
    Not necessarily convinced that exactly this approach is the way to go, but IMO it's worth considering.
    vbuterin authored Mar 31, 2019
    Configuration menu
    Copy the full SHA
    b6be9e1 View commit details
    Browse the repository at this point in the history
  2. Update 0_beacon-chain.md

    JustinDrake authored Mar 31, 2019
    Configuration menu
    Copy the full SHA
    79d1f9f View commit details
    Browse the repository at this point in the history
  3. Update 0_beacon-chain.md

    JustinDrake authored Mar 31, 2019
    Configuration menu
    Copy the full SHA
    c2edceb View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Configuration menu
    Copy the full SHA
    37fc79c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Configuration menu
    Copy the full SHA
    2f1ab49 View commit details
    Browse the repository at this point in the history
  2. fix tests for get_domain PR

    djrtwo committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    dd520c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. Update 0_beacon-chain.md

    JustinDrake authored Apr 17, 2019
    Configuration menu
    Copy the full SHA
    24492aa View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. Configuration menu
    Copy the full SHA
    5238008 View commit details
    Browse the repository at this point in the history