-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible aesthetic rework to get_domain #865
Merged
Merged
Commits on Mar 31, 2019
-
Possible aesthetic rework to get_domain
In general I dislike how domains, which should be an unobtrusive out-of-the-way thing that we don't think about much, are taking up so much space in code to express, to the point of them being the single thing preventing `bls_verify` from being expressed in one line of code. Here I reorder arguments and add a default, and make `bls_verify` a one-liner. Not necessarily convinced that exactly this approach is the way to go, but IMO it's worth considering.
Configuration menu - View commit details
-
Copy full SHA for b6be9e1 - Browse repository at this point
Copy the full SHA b6be9e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79d1f9f - Browse repository at this point
Copy the full SHA 79d1f9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2edceb - Browse repository at this point
Copy the full SHA c2edcebView commit details
Commits on Apr 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 37fc79c - Browse repository at this point
Copy the full SHA 37fc79cView commit details
Commits on Apr 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2f1ab49 - Browse repository at this point
Copy the full SHA 2f1ab49View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd520c6 - Browse repository at this point
Copy the full SHA dd520c6View commit details
Commits on Apr 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 24492aa - Browse repository at this point
Copy the full SHA 24492aaView commit details
Commits on Apr 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5238008 - Browse repository at this point
Copy the full SHA 5238008View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.