Closed
Conversation
jtraglia
reviewed
Nov 26, 2025
Member
There was a problem hiding this comment.
Please run make lint to format the file.
jtraglia
reviewed
Nov 26, 2025
tests/checklists/eip7732.md
Outdated
|
|
||
| #### Expectation | ||
|
|
||
| Bid is accepted, latest_execution_payload_bid is updated in state, and no pending payment is created since value is zero. |
Member
There was a problem hiding this comment.
There are many instances of inline code which are not shown as code. Eg latest_execution_payload_bid.
jtraglia
reviewed
Nov 26, 2025
tests/checklists/eip7732.md
Outdated
|
|
||
| #### Expectation | ||
|
|
||
| Bid is accepted, latest_execution_payload_bid is updated, builder balance remains unchanged, and a pending payment is created in the builder_pending_payments queue with weight = 0 and withdrawable_epoch = FAR_FUTURE_EPOCH. |
Member
There was a problem hiding this comment.
I would prefer we don't do the "variable = value" thing & instead write it as a proper sentence. Mostly for consistency; see the scenario section immediately above which does this.
Member
Author
|
This PR is still in draft |
21 tasks
Member
Author
|
Remove the ids of the categories, also from the title of the test case |
leolara
force-pushed
the
leolara/eip7732_checklist
branch
from
d2e565f to
d2647da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.