Skip to content

Test that verify_data_column_sidecar respects the blob limit #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtraglia merged 2 commits into from
Oct 23, 2025
Merged

Test that verify_data_column_sidecar respects the blob limit #4690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36fed4
Test for verify_data_column_sidecars
leolara Oct 23, 2025
bd988ac
Fix test names
jtraglia Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion tests/core/pyspec/eth2spec/test/fulu/unittests/test_networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,32 @@ def test_verify_data_column_sidecar__invalid_mismatch_len_kzg_commitments(spec,
@with_fulu_and_later
@spec_state_test
@single_phase
def test_verify_data_column_sidecars__invalid_mismatch_len_kzg_proofs(spec, state):
def test_verify_data_column_sidecar__invalid_mismatch_len_kzg_proofs(spec, state):
sidecar = compute_data_column_sidecar(spec, state)
sidecar.kzg_proofs = sidecar.kzg_proofs[1:]
assert not spec.verify_data_column_sidecar(sidecar)


@with_fulu_and_later
@spec_state_test
@single_phase
def test_verify_data_column_sidecar__invalid_kzg_commitments_over_max_blobs(spec, state):
sidecar = compute_data_column_sidecar(spec, state)

if is_post_gloas(spec):
slot = sidecar.slot
else:
slot = sidecar.signed_block_header.message.slot
epoch = spec.compute_epoch_at_slot(slot)
max_blobs = spec.get_blob_parameters(epoch).max_blobs_per_block

for _ in range(max_blobs - len(sidecar.kzg_commitments) + 1):
sidecar.kzg_commitments.append(sidecar.kzg_commitments[0])
assert len(sidecar.kzg_commitments) > max_blobs

assert not spec.verify_data_column_sidecar(sidecar)


# Tests for verify_data_column_sidecar_kzg_proofs


Expand Down