lint(utils): mark unused description param in vector_test (fixes #4659)#4663
lint(utils): mark unused description param in vector_test (fixes #4659)#4663omegajudith wants to merge 2 commits intoethereum:masterfrom
description param in vector_test (fixes #4659)#4663Conversation
b84e850 to
943c135
Compare
|
Why is also removing the other function? The goal should be to remove the parameter, but I am also doing it together with other things here: #4658 |
|
I am still on it . I am fixing it still |
…ionally unused (fixes ethereum#4659)
eb6a6b8 to
514edd8
Compare
|
@leolara please take alook if get a minute |
|
this will create conflict here: #4658 and that ones removes it. @omegajudith have a look at this one: #4602 i don't think anyone is working on that, and it is self contain. A bit more difficult but will help you learn how the reftests work more. |
|
Thank you very much @leolara , let me surely read on tis |
That if we merged this PR, it will cause a merge conflict with the other one, that removes actually the parameter that is not used, and also does more things like add unit tests. |
|
Ah, okay I understand. That was well explained. So now you say I should stop working on that and start working on issue 4602? Should I set 4659 back to you upstream? Coz now Iam going to start working on 4602 |
|
Yes, so it seems that one is taken, we will come up with another one probably |
Fixes #4659.
tests/core/pyspec/eth2spec/test/utils/utils.py:vector_testdecorator accepted adescriptionargument that was never used._descriptionto indicate intentional non-use and satisfy the linter.No behavioral changes; only a lint/clarity update.
Ran
make lintlocally.