Skip to content

Comments

lint(utils): mark unused description param in vector_test (fixes #4659)#4663

Closed
omegajudith wants to merge 2 commits intoethereum:masterfrom
omegajudith:4659-vector-test-desc-unused
Closed

lint(utils): mark unused description param in vector_test (fixes #4659)#4663
omegajudith wants to merge 2 commits intoethereum:masterfrom
omegajudith:4659-vector-test-desc-unused

Conversation

@omegajudith
Copy link
Contributor

Fixes #4659.

tests/core/pyspec/eth2spec/test/utils/utils.py:

  • The vector_test decorator accepted a description argument that was never used.
  • Renamed it to _description to indicate intentional non-use and satisfy the linter.

No behavioral changes; only a lint/clarity update.
Ran make lint locally.

@omegajudith omegajudith force-pushed the 4659-vector-test-desc-unused branch from b84e850 to 943c135 Compare October 17, 2025 05:26
@leolara
Copy link
Member

leolara commented Oct 17, 2025

Why is also removing the other function?

The goal should be to remove the parameter, but I am also doing it together with other things here: #4658

@omegajudith
Copy link
Contributor Author

I am still on it . I am fixing it still

@omegajudith omegajudith force-pushed the 4659-vector-test-desc-unused branch from eb6a6b8 to 514edd8 Compare October 17, 2025 05:54
@omegajudith
Copy link
Contributor Author

@leolara please take alook if get a minute

@omegajudith
Copy link
Contributor Author

@jtraglia , @leolara feed back please. so i can fix

@leolara
Copy link
Member

leolara commented Oct 17, 2025

this will create conflict here: #4658 and that ones removes it.

@omegajudith have a look at this one: #4602

i don't think anyone is working on that, and it is self contain. A bit more difficult but will help you learn how the reftests work more.

@omegajudith
Copy link
Contributor Author

Thank you very much @leolara , let me surely read on tis

@omegajudith
Copy link
Contributor Author

@leolara you said: >>> this will create conflict here: #4658 and that ones removes it.

i didnt understand this part, >>>> and that ones removes it.

please help clarify. thank you

@leolara
Copy link
Member

leolara commented Oct 17, 2025

@leolara you said: >>> this will create conflict here: #4658 and that ones removes it.

i didnt understand this part, >>>> and that ones removes it.

please help clarify. thank you

That if we merged this PR, it will cause a merge conflict with the other one, that removes actually the parameter that is not used, and also does more things like add unit tests.

@omegajudith
Copy link
Contributor Author

Ah, okay I understand. That was well explained.

So now you say I should stop working on that and start working on issue 4602?

Should I set 4659 back to you upstream? Coz now Iam going to start working on 4602

@leolara leolara closed this Oct 18, 2025
@leolara
Copy link
Member

leolara commented Oct 18, 2025

Yes, so it seems that one is taken, we will come up with another one probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decorator vector_test has parameter description is never used

2 participants