Skip to content

Fix decorator order in light-client tests #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtraglia merged 3 commits into from
Oct 17, 2025
Merged

Fix decorator order in light-client tests #4652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c2c938
tests/context: drain generator return so pytest doesn't warn (PytestR…
omegajudith Oct 13, 2025
c85f370
tests(altair/light-client): place @spec_state_test_with_matching_conf…
omegajudith Oct 16, 2025
92837f0
revert: keep PR focused on decorator order; drop context/utils change
omegajudith Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/core/pyspec/eth2spec/test/altair/light_client/test_data_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(initial_epoch=1, interval=1),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_light_client_data_collection(spec, state):
# Start test
Expand Down
8 changes: 4 additions & 4 deletions tests/core/pyspec/eth2spec/test/altair/light_client/test_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_light_client_sync(spec, state):
# Start test
Expand Down Expand Up @@ -289,13 +289,13 @@ def test_light_client_sync(spec, state):


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_supply_sync_committee_from_past_update(spec, state):
# Advance the chain, so that a `LightClientUpdate` from the past is available
Expand Down Expand Up @@ -329,13 +329,13 @@ def test_supply_sync_committee_from_past_update(spec, state):


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_advance_finality_without_sync_committee(spec, state):
# Start test
Expand Down Expand Up @@ -423,13 +423,13 @@ def test_advance_finality_without_sync_committee(spec, state):


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_light_client_sync_no_force_update(spec, state):
"""Test that force update does not occur before timeout threshold is reached.
Expand Down
8 changes: 4 additions & 4 deletions tests/core/pyspec/eth2spec/test/altair/unittests/light_client/test_sync_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ def setup_test(spec, state):


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
def test_process_light_client_update_not_timeout(spec, state):
genesis_block, store = setup_test(spec, state)

Expand Down Expand Up @@ -70,13 +70,13 @@ def test_process_light_client_update_not_timeout(spec, state):


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_process_light_client_update_at_period_boundary(spec, state):
genesis_block, store = setup_test(spec, state)
Expand Down Expand Up @@ -111,13 +111,13 @@ def test_process_light_client_update_at_period_boundary(spec, state):


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_process_light_client_update_timeout(spec, state):
genesis_block, store = setup_test(spec, state)
Expand Down Expand Up @@ -152,13 +152,13 @@ def test_process_light_client_update_timeout(spec, state):


@with_light_client
@spec_state_test_with_matching_config
@with_config_overrides(
{
"BLOB_SCHEDULE": sample_blob_schedule(),
},
emit=False,
)
@spec_state_test_with_matching_config
@with_presets([MINIMAL], reason="too slow")
def test_process_light_client_update_finality_updated(spec, state):
_, store = setup_test(spec, state)
Expand Down