Skip to content

eip7732: use correct late block cutoff time in proposer boost tests #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtraglia merged 1 commit into from
Aug 12, 2025
Merged

eip7732: use correct late block cutoff time in proposer boost tests #4501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions tests/core/pyspec/eth2spec/test/phase0/fork_choice/test_on_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,12 @@ def test_proposer_boost(spec, state):

# Process block on timely arrival just before end of boost interval
# Round up to nearest second
late_block_cutoff_ms = spec.get_slot_component_duration_ms(spec.config.ATTESTATION_DUE_BPS)
if is_post_eip7732(spec):
late_block_cutoff_ms = spec.get_slot_component_duration_ms(
spec.config.ATTESTATION_DUE_BPS_EIP7732
)
else:
late_block_cutoff_ms = spec.get_slot_component_duration_ms(spec.config.ATTESTATION_DUE_BPS)
late_block_cutoff = (late_block_cutoff_ms + 999) // 1000
time = store.genesis_time + block.slot * spec.config.SECONDS_PER_SLOT + late_block_cutoff - 1

Expand Down Expand Up @@ -612,7 +617,12 @@ def test_proposer_boost_root_same_slot_untimely_block(spec, state):

# Process block on untimely arrival in the same slot
# Round up to nearest second
late_block_cutoff_ms = spec.get_slot_component_duration_ms(spec.config.ATTESTATION_DUE_BPS)
if is_post_eip7732(spec):
late_block_cutoff_ms = spec.get_slot_component_duration_ms(
spec.config.ATTESTATION_DUE_BPS_EIP7732
)
else:
late_block_cutoff_ms = spec.get_slot_component_duration_ms(spec.config.ATTESTATION_DUE_BPS)
late_block_cutoff = (late_block_cutoff_ms + 999) // 1000
time = store.genesis_time + block.slot * spec.config.SECONDS_PER_SLOT + late_block_cutoff

Expand Down Expand Up @@ -653,7 +663,12 @@ def test_proposer_boost_is_first_block(spec, state):

# Process block on timely arrival just before end of boost interval
# Round up to nearest second
late_block_cutoff_ms = spec.get_slot_component_duration_ms(spec.config.ATTESTATION_DUE_BPS)
if is_post_eip7732(spec):
late_block_cutoff_ms = spec.get_slot_component_duration_ms(
spec.config.ATTESTATION_DUE_BPS_EIP7732
)
else:
late_block_cutoff_ms = spec.get_slot_component_duration_ms(spec.config.ATTESTATION_DUE_BPS)
late_block_cutoff = (late_block_cutoff_ms + 999) // 1000
time = store.genesis_time + block_a.slot * spec.config.SECONDS_PER_SLOT + late_block_cutoff - 1

Expand Down