Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues in new random execution requests #4044

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

jtraglia
Copy link
Member

  • Rename methods so the request type isn't plural.
    • For example, get_random_deposits_requests to get_random_deposit_requests.
  • Set DepositRequest.index to rng.randrange(0, 2**64).
    • In Electra, index doesn't exist in deposit data.
    • I would have done rng.randint(0, UINT64_MAX) but this is an alias of randrange(a, b+1) and we cannot increment the max uint64 value again. Kind of a weird edge case.
  • Delete some whitespace & fix some organization nits.

@jtraglia
Copy link
Member Author

Going to merge now to fix test vectors.

@jtraglia jtraglia merged commit d8276ac into ethereum:dev Dec 10, 2024
27 checks passed
@jtraglia jtraglia deleted the fix-random-exec-requests branch December 10, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant