Fix test cases file path in sanity test generator
#4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
reviewed
Nov 29, 2024
| @@ -31,10 +31,13 @@ | |||
| # This is a "hack" which allows other test files (e.g., test_deposit_transition.py) | |||
| # to reuse the sanity/block test format. If a new test file is added or removed, | |||
| # do not forget to update sanity/block/__init__.py accordingly. | |||
| _new_electra_mods = {key: 'eth2spec.test.electra.sanity.' + key for key in [ | |||
| _new_electra_mods_1 = {key: 'eth2spec.test.electra.sanity.' + key for key in [ | |||
There was a problem hiding this comment.
maybe just have
_new_electra_mods = {key: 'eth2spec.test.electra.sanity.' + key for key in [
'blocks',
'test_slots’,
]}There was a problem hiding this comment.
I tried that at the beginning, but due to the key field, it would give us a folder /test_slots/pyspec_tests/* for the test vectors.
There was a problem hiding this comment.
What I did locally was to just create a slots folder with __init__.py to match what's done for blocks
from .test_slots import * # noqa: F401 F403but as noted in the comment, probably not ideal either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the leftover of #4024.
Thank @nflaig for reporting it!