Update initial earliest_exit_epoch
calculation & add tests
#4001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up when discussing an edge case: what is the correct
earliest_exit_epoch
value given a state where the greatest validator exit epoch is less than the current epoch. For example, given a state with one validator and its exit epoch is 3, current epoch is 100, shouldearliest_exit_epoch
be 4? That doesn't seem right.I believe it should be at least
compute_activation_exit_epoch(get_current_epoch(pre)) + 1
. And updated tovalidator.exit_epoch + 1
if there is a validator with a greater exit epoch.