Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject invalid DataColumnSidecar for zero blobs #3953

Merged
merged 12 commits into from
Oct 3, 2024
Merged

Reject invalid DataColumnSidecar for zero blobs #3953

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
578407a
Reject invalid DataColumnSidecar for zero blobs
jtraglia Oct 2, 2024
3f49e6c
Deepcopy sidecar before modifying it
jtraglia Oct 2, 2024
4578b59
Use wrapper function which does the deepcopy
jtraglia Oct 2, 2024
df987b5
Create new verify_data_column_sidecar() function
jtraglia Oct 2, 2024
09cc204
Add an extra blank line for consistency
jtraglia Oct 2, 2024
e02cbab
Move index check to top
jtraglia Oct 2, 2024
3984bd3
Convert assert to return False
jtraglia Oct 2, 2024
3196487
Add missing semicolon
jtraglia Oct 2, 2024
2ceb0fd
Fix some nits
jtraglia Oct 2, 2024
3e80dc8
Add new verification to is_data_available
jtraglia Oct 3, 2024
30f6aba
Put "and" at the beginning of the next line
jtraglia Oct 3, 2024
62c32da
Be more consistent with test names
jtraglia Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add new verification to is_data_available
  • Loading branch information
@jtraglia
jtraglia committed Oct 3, 2024
commit 3e80dc8ed02000ab9f3faee036d1fe565461d5eb
1 change: 1 addition & 0 deletions specs/_features/eip7594/fork-choice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def is_data_available(beacon_block_root: Root) -> bool:
# `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` epochs.
column_sidecars = retrieve_column_sidecars(beacon_block_root)
return all(
verify_data_column_sidecar(column_sidecar) and
verify_data_column_sidecar_kzg_proofs(column_sidecar)
jtraglia marked this conversation as resolved.
Show resolved Hide resolved
for column_sidecar in column_sidecars
)
Expand Down