Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronously check all transactions to have non-zero length #3885

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Synchronously check all transactions to have non-zero length #3885

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1eaa7f
Synchronously check all `transactions` to have non-zero length
etan-status Aug 14, 2024
c746890
Merge branch 'dev' into bf-emptytxspec
etan-status Sep 19, 2024
1e96d23
Merge branch 'dev' into bf-emptytxspec
etan-status Oct 9, 2024
a6095bf
Update specs/deneb/beacon-chain.md
etan-status Oct 21, 2024
f58b5ba
Merge branch 'dev' into bf-emptytxspec
etan-status Oct 21, 2024
44d5a1b
Sync changes to Electra
etan-status Oct 21, 2024
0f964b0
Change "modified" to "new"
jtraglia Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Sync changes to Electra
  • Loading branch information
@etan-status
etan-status committed Oct 21, 2024
commit 44d5a1b49bffbddc79f9a49ca4245c7ef0e7c693
3 changes: 3 additions & 0 deletions specs/electra/beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,9 @@ def verify_and_notify_new_payload(self: ExecutionEngine,
parent_beacon_block_root = new_payload_request.parent_beacon_block_root
execution_requests_list = get_execution_requests_list(new_payload_request.execution_requests) # [New in Electra]

if b'' in execution_payload.transactions:
return False

if not self.is_valid_block_hash(execution_payload, parent_beacon_block_root):
return False

Expand Down