-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add correct type casts to eip7594 functions #3697
Conversation
The invalid base class error comes from I suspect that the issue arises because the size of the list is not a literal |
6651612
to
9c9f8f1
Compare
…ss Container(List[c, a*b])`
I've removed the check from the CI, since this PR is very prone to having merge conflicts. There seems to be an underlying issue that I've yet to investigate (CI timing out) |
1cd63df
to
8ec433c
Compare
8ec433c
to
6eb5756
Compare
is this PR still active? or can we close for being stale? looks like the problem this PR addresses has been handled in other ways since? |
I've merged in most of the changes for this in separate PRs, we haven't enabled type casts because the CI kept timing out (happy to close and re-open a new PR when I have more time to investigate the typing issue -- the code has been updated since) |
. |
1 similar comment
. |
cc @hwwhww
This PR resolves all of the errors for eip7594.
I applied a workarounf for the error
error: Invalid base class "List"
-- Happy to revert if there is a better solution.